Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _33 keyboard support #312

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add _33 keyboard support #312

merged 1 commit into from
Oct 19, 2020

Conversation

tominabox1
Copy link
Contributor

Description

Add _33 (underscore33) Rev1 and Rev2 support.

qmk/qmk_firmware#9899 (merged)

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

2Moons-JP
2Moons-JP approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@2Moons-JP 2Moons-JP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked both keymaps to QMK and matched both VID and PID numbers.

@wilba wilba merged commit 4e1a07f into the-via:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2Moons-JP 2Moons-JP 2Moons-JP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tominabox1 @2Moons-JP @wilba